Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the FindClus block size [14.0.x] #44082

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Feb 26, 2024

PR description:

Compute the FindClus block size from the maximum number of hits per module, and harmonise the block size used for the kernel launch and inside the kernel itself.

PR validation:

Fixes #44077.

Backport

Backport of #44081.

Compute the FindClus block size from the maximum number of hits per module.

Harmonise the block size used for the kernel launch and inside the kernel itself.
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 26, 2024

A new Pull Request was created by @fwyzard for CMSSW_14_0_X.

It involves the following packages:

  • RecoLocalTracker/SiPixelClusterizer (reconstruction)

@mandrenguyen, @cmsbuild, @jfernan2 can you please review it and eventually sign? Thanks.
@tvami, @mtosi, @mmusich, @ferencek, @felicepantaleo, @missirol, @rovere, @VinInn, @JanFSchulte, @threus, @VourMa, @gpetruc, @mroguljic, @dkotlins, @GiacomoSguazzoni this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 26, 2024

cms-bot internal usage

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 26, 2024

type bugfix

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 26, 2024

backport #44081

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 26, 2024

enable gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 26, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14086b/37678/summary.html
COMMIT: 85c769b
CMSSW: CMSSW_14_0_X_2024-02-25-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44082/37678/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 35 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 1404
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 38336
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 26, 2024

urgent

for 2024 data taking

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild cmsbuild removed the backport label Feb 26, 2024
@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7874d41 into cms-sw:CMSSW_14_0_X Feb 28, 2024
13 checks passed
@fwyzard fwyzard deleted the fix_FindClus_block_size_140x branch March 2, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants